2017-04-15 8:38 GMT-07:00 Jonathan Liu <net147@xxxxxxxxx>:
> Hi Sachin,
>
> On 21 October 2016 at 10:52, Sachin Prabhu <sprabhu@xxxxxxxxxx> wrote:
>>
>> Commit 4fcd1813e640 ("Fix reconnect to not defer smb3 session reconnect
>> long after socket reconnect") changes the behaviour of the SMB2 echo
>> service and causes it to renegotiate after a socket reconnect. However
>> under default settings, the echo service could take up to 120 seconds to
>> be scheduled.
>>
>> The patch forces the echo service to be called immediately resulting a
>> negotiate call being made immediately on reconnect.
>>
>> Signed-off-by: Sachin Prabhu <sprabhu@xxxxxxxxxx>
>> Reviewed-by: Pavel Shilovsky <pshilov@xxxxxxxxxxxxx>
>
> This commit is causing a flood of connections to Samba server as well
> as high server CPU load when the Samba is restarted while CIFS share
> is mounted on the client. This can cause the Samba server to become
> slow or unresponsive resulting in denial of service to other users
> connected to the Samba server.
>
> Bug report: https://bugzilla.kernel.org/show_bug.cgi?id=194531
>
> Could you please have a look?
>
> Thanks.
>
> Regards,
> Jonathan
> --
> To unsubscribe from this list: send the line "unsubscribe linux-cifs" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Jonathan,
Thanks for reporting this.
It seems like we need to make CIFSSMBEcho() call as noop in case of
(server->tcpStatus == CifsNeedNegotiate) as we already did for
SMB2_echo().
--
Best regards,
Pavel Shilovsky
--
To unsubscribe from this list: send the line "unsubscribe linux-cifs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
