merged into cifs-2.6.git for-next and cc: stable Good catch - thx On Wed, Nov 30, 2016 at 11:32 AM, Aurélien Aptel <aaptel@xxxxxxxx> wrote: > Hi Mark, > > New setup > > PS> net user guest /activate:no > PS> mkdir C:\guestshare > PS> icacls C:\guestshare /grant 'Everyone:(OI)(CI)F' > PS> new-smbshare -name guestshare -path C:\guestshare -fullaccess Everyone > > I've tested v3.10, v4.4, master, master+your patch using default options > (empty or no user "NU") and user=abc (U). > > NT_LOGON_FAILURE in session setup: LF > This is what you seem to have in 3.10. > > NT_ACCESS_DENIED in tree connect to the share: AD > This is what you get before your infinite loop. > > | NU U > -------------------------------- > 3.10 | LF LF > 4.4 | LF LF > master | AD LF > master+patch | AD LF > > No infinite DFS loop :( > All these issues result in mount failing very fast with permission denied. > > I guess it could be from either the Windows version or the share/folder > ACL. A deeper analysis of the packets might reveal more. > > In any case I did not notice any issues for on a basic DFS setup with > the patch so I don't think it introduced any regressions, which is > probably all that matters. It still bothers me a little I couldn't hit > the bug. > > I've included kernel output w/ debugging output and network capture of > my tests if anyone want to have a look at it. (master+patch = ml-guestfix). > > Reviewed-by: Aurelien Aptel <aaptel@xxxxxxxx> > Tested-by: Aurelien Aptel <aaptel@xxxxxxxx> > > > > -- > Aurélien Aptel / SUSE Labs Samba Team > GPG: 1839 CB5F 9F5B FB9B AA97 8C99 03C8 A49B 521B D5D3 > SUSE Linux GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany > GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg) > -- Thanks, Steve -- To unsubscribe from this list: send the line "unsubscribe linux-cifs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
