Hi Pavel, Pavel Shilovsky <piastryyy@xxxxxxxxx> writes: > Accessing the tcon_list should be protected by spin_locks and also a > reference to the tcon should be acquired before using it safely. I've noticed we have the cifs_tcp_ses_lock but also a per-session session_mutex. I'm guessing we want cifs_tcp_ses_lock here. By acquiring a reference you mean incrementing/decrementing tc_count. Do we need to protect this inc/dec operation with cifs_tcp_ses_lock too? > Also you can extend SMB2_ioctl argument list to allow passing ipc_tid. > In this case SMB2_ioctl() can choose what to use - ipc_tid or tcon; if > tcon is passed -use it, otherwise - use ipc_tid. > > In this case you can fallback to ipc_tid if no tcon is found in the list. > SMB2_ioctl() uses the tcon for many things. I don't see how we can just use ipc_tid number if we don't pass a tcon. Or do you mean: add a use_ipc bool to SMB2_ioctl arg list and use the tcon as usual except overwrite the Tid field with ses->ipc_tid before sending? Thanks, -- Aurélien Aptel / SUSE Labs Samba Team GPG: 1839 CB5F 9F5B FB9B AA97 8C99 03C8 A49B 521B D5D3 SUSE Linux GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg) -- To unsubscribe from this list: send the line "unsubscribe linux-cifs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
