Re: Fix SMB2_TREE_CONNECT requests with the wrong TreeId

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Am 14.02.2017 um 17:02 schrieb Aurélien Aptel:
> Jan-Marek Glogowski <glogow@xxxxxxxxxx> writes:
>> I also had a look at the CIFS code and the tcon->tid member is just used
>> to set the SMB2 header TreeId field or is set from the the SMB2 header
>> TreeId field. If tcon structs are reused, I couldn't see a code path to
>> zero it.
> 
> wasn't thinking of the reconnection, good catch!
> 
> I'm still not sure why you got the stacktrace on the old kernel. I'll
> try it out.

The trace starts with

[ 1815.635294] WARNING: CPU: 1 PID: 65 at
/tmp/cifs-3.13.0-100.147-patched/smb2pdu.c:164
small_smb2_init+0x246/0x560 [cifs]()

which is the place of the WARN call in my code. Since I also had a patch
for a newer kernel (Ubuntu 16.04 HWE for 14.04 AKA Linux 4.4), the
offsets are wrong in the attached patch.

I just re-checked my code. I didn't test the non-WARN variant and
assumed the code simply got inlined, so the function name is wrong.

Jan-Marek
--
To unsubscribe from this list: send the line "unsubscribe linux-cifs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux