Sachin Prabhu <sprabhu@xxxxxxxxxx> writes: > We have an inline helper convert_delimiter() which already does this. > The block for dfsplen also seems to repeat the code. Correct except for a small detail: the inline helper does the conversion until the end of the string. Here we need to stop in the middle. > Can we use the helper for the complete patch instead when the > full_path variable is available? We do not want to mess with unix path that might contain a valid backslash inside a path component. > I think the code here for copying the treename and the prefixpath name > can also be cleaned to make it easier to read ie. move the treeName > copy before we copy over the prefix path. Agreed. Thanks for the feedback, Sachin. I'll send an updated patch for review. -- Aurélien Aptel / SUSE Labs Samba Team GPG: 1839 CB5F 9F5B FB9B AA97 8C99 03C8 A49B 521B D5D3 SUSE Linux GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg) -- To unsubscribe from this list: send the line "unsubscribe linux-cifs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
