On Thu, 2016-09-08 at 12:49 +0200, Aurélien Aptel wrote:
> Hi Sachin,
>
> As you said, patch is similar to what I proposed few month ago.
> There's
> only one thing that bothers me. cifs_build_path_to_root() has this
> bit
> before the DFS test:
>
> /* if no prefix path, simply set path to the root of share to
> "" */
> if (pplen == 0) {
> full_path = kzalloc(1, GFP_KERNEL);
> return full_path;
> }
>
>
> I think it should be dropped. It was already inconsistent because if
> the
> share was in a DFS without a prepath it would have returned an empty
> string instead of a path with the tree name prefix.
>
> I can send a patch after yours to correct that you think it should be
> in
> a separate commit.
>
> Cheers,
>
I suspect that is because the root of the share cannot be a DFS mount.
Maybe Steve can confirm it.
Sachin Prabhu
--
To unsubscribe from this list: send the line "unsubscribe linux-cifs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
