On Sun, Dec 06, 2015 at 04:53:31PM -0800, Darrick J. Wong wrote: > > + if (S_ISDIR(inode_in->i_mode) || S_ISDIR(inode_out->i_mode)) > > + return -EISDIR; > > + if (!S_ISREG(inode_in->i_mode) || !S_ISREG(inode_out->i_mode)) > > + return -EOPNOTSUPP; > > I thought we were moving to -EINVAL for wrong file types? > > Though, perhaps "I've also prepared a btrfs patch for this and clone" from the > earlier thread about generic/157 wasn't referring to /this/ patch. :) > > In any case, I'm ok with EINVAL, and I haven't heard any objections to > changing -EOPNOTSUPP -> -EINVAL when trying to reflink/dedupe/whatever > non-file non-dir fds. I'm fine with with EINVAL - not sure why I ended up with EOPNOTSUP, probably because 157 is already failing as in general the errors for something in the VFS vs a specific ioctl handler are just too different. -- To unsubscribe from this list: send the line "unsubscribe linux-cifs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
