Re: [PATCH 1/5] cifs: implement clone_file_range operation

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Nov 27, 2015 at 11:42:32AM +0100, David Disseldorp wrote:
> I think that's about as close as we're going to get to clone semantics
> for cifs. It's also dispatched as a single request covering the full
> file - chunking only occurs for CIFS_IOC_COPYCHUNK_FILE based requests,
> which are implemented using FSCTL_SRV_COPYCHUNK_WRITE, and not (always)
> handled by the server as a COW clone.

Oh, I misread cifs_ioctl_clone - it does two entirely different things
based on the dup_extents parameter.  It looked like it did both
of them in the dup_extents case.  Re-reading the code it seems close
enough, although the client side samping of the file size seems a little
dangerous.

I'll wire it up for clone_file_range for the next respin, but I'm still
a little worried.
--
To unsubscribe from this list: send the line "unsubscribe linux-cifs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux