On 28 Sep 2015 at 15:57, Steve French wrote: > > FTR, this issue was detected with the upcoming version of the size overflow > > plugin we have in PaX/grsecurity and there're a handful of similar cases in > > the tree where potentially unwanted or unnecessary integer truncations occur, > > this being one of these. any opinion/help is welcome! > > If you find others let me know (other than the identical bug in the > error path immediately below the one you just pointed out). sure, i will, though the current (very specific) analysis found only those questionable cases that i reported (here and some other lists). if you (or anyone else) have ideas for more specific analysis (checking invariants, API use, etc), we can take a look though gcc plugins have very limited view on the source code, so only those properties can be checked that are still visible in the middle end (we found the above case exactly because the underlying code looks the same whether the integer truncation is intentional or not, so we had to exclude them as false positives in our instrumentation but still wanted to manually verify them). PS: it seems that you didn't CC me on the actual patch ;) -- To unsubscribe from this list: send the line "unsubscribe linux-cifs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
