On Wed, Nov 12, 2014 at 10:40:35PM -0600, Steve French wrote: > On Wed, Nov 12, 2014 at 10:27 PM, Dave Chinner <david@xxxxxxxxxxxxx> wrote: > > On Wed, Nov 12, 2014 at 10:08:34PM -0600, Steve French wrote: > >> On Wed, Nov 12, 2014 at 9:28 PM, Dave Chinner <david@xxxxxxxxxxxxx> wrote: > >> > On Wed, Nov 12, 2014 at 05:26:13PM -0600, Steve French wrote: > >> >> I get newly enabled test 294 passing on cifs mounts to Samba. > >> >> > >> >> What is best way to get the mount options passed to the mount of > >> >> scratch dev so it doesn't prompt for it? > >> > > >> > # MOUNT_OPTIONS="-o ...." ./check -g auto > >> > >> much better - that worked - thanks > >> > >> I had been using TEST_FS_MOUNT_OPTS (so I could have multiple sections > >> in local.config) rather > >> than MOUNT_OPTIONS > > > > BTW, why aren't you using CIFS_MOUNT_OPTIONS to define the login > > creds for both the test and scratch devices? That's what it was > > added for.... > > When specifying multiple sections in local.config (a common case for us > is to have one section to run tests with cifs dialect, then run again with > smb2, then again with smb3 dialect etc.). Pavel had indicated that to do this > you must use TEST_FS_MOUNT_OPTS instead of CIFS_MOUNT_OPTIONS > if you have multiple sections. I haven't found a way around this. Adding CIFS_MOUNT_OPTIONS in each section that requires a different definition should just work. If it doesn't, then please fix get_next_config() so it does and post the patch.... -Dave. -- Dave Chinner david@xxxxxxxxxxxxx -- To unsubscribe from this list: send the line "unsubscribe linux-cifs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html