> 27 авг. 2014 г., в 19:58, Christoph Hellwig <hch@xxxxxxxxxxxxx> написал(а): > >> On Wed, Aug 27, 2014 at 12:28:38AM +0400, Pavel Shilovsky wrote: >> CIFS/SMB protocol without POSIX extensions doesn't support operations >> with symbolic links and advisory byte-range locks from the same process. >> Add a check for nounix mounts and use it in generic tests that >> require such operations. > > +_require_test_posix_ext seems very cifs specific. Can you take > a look at the tests and see what posix feature they require and > add features based on that? Let's have a quick discussion here on the > requirements of the tests before even writing the code. > Agree. >> diff --git a/tests/generic/005 b/tests/generic/005 >> index d78e43f..0c2b51f 100755 >> --- a/tests/generic/005 >> +++ b/tests/generic/005 >> @@ -67,6 +67,7 @@ _touch() >> # real QA test starts here >> _supported_fs generic >> _require_test >> +_require_test_posix_ext >> >> # IRIX UDF does not support symlinks >> if [ $FSTYP == 'udf' ]; then > > this suggest 005 needs symlinks and plain cifs doesn't support them. > We should also fold this test for IRIX udf into the _requires_symlink > tests. > >> diff --git a/tests/generic/023 b/tests/generic/023 >> index 114485c..91b8a37 100755 >> --- a/tests/generic/023 >> +++ b/tests/generic/023 >> @@ -45,6 +45,7 @@ _supported_os Linux >> >> _require_test >> _requires_renameat2 >> +_require_test_posix_ext > > > 023-025 just require a working renameat2, and nothing in Posix. What's > the problem for cifs here? These tests try to create symlinks and then rename them. > >> diff --git a/tests/generic/131 b/tests/generic/131 >> index b4e3ff0..9736963 100755 >> --- a/tests/generic/131 >> +++ b/tests/generic/131 >> @@ -45,6 +45,7 @@ _cleanup() >> _supported_fs generic >> _supported_os Linux >> _require_test >> +_require_test_posix_ext >> >> TESTFILE=$TEST_DIR/lock_file > > 131 tests fcntl style file locking, so we should test for that. > > -- > To unsubscribe from this list: send the line "unsubscribe linux-cifs" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html So for these tests we need two check functions: _require_symlink for 005, 023, 024, 025 and _require_fcntl for 131. Right? -- Best regards, Pavel Shilovsky.-- To unsubscribe from this list: send the line "unsubscribe linux-cifs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
