On Sun, 24 Aug 2014 09:10:46 -0700 Christoph Hellwig <hch@xxxxxxxxxxxxx> wrote: > One more wishlist item in addition to the one mentioned in the patches: > > - add a return value to lm_break so that the lock manager can tell the > core code "you can delete this lease right now". That gets rid of > the games with the timeout which require all kinds of race avoidance > code in the users. > I'm not sure I understand what you're suggesting here. Isn't it just as simple to have lm_break call lease_modify to just remove the lease? > And a big one that doesn't seem easily addressable, but I'll drop it in > anyway: > > - calling ->lm_break without i_lock would make everyones life a heck > lot easier.. > Indeed. I have some ideas for a larger cleanup of the file locking code. This series is really sort of prep work for that overhaul, and I'm hoping we'll be able to do something along those lines. -- Jeff Layton <jlayton@xxxxxxxxxxxxxxx> -- To unsubscribe from this list: send the line "unsubscribe linux-cifs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
