On Sat, Aug 23, 2014 at 10:41:14AM -0400, Jeff Layton wrote: > In later patches, we're going to add a new lock_manager_operation to > finish setting up the lease while still holding the i_lock. To do > this, we'll need to pass a little bit of info in the fcntl setlease > case (primarily an fasync structure). Plumb the extra pointer into > there in advance of that. > > We declare this pointer as a void ** to make it clear that this is > auxillary info, and that the caller isn't required to set this unless > the lm_setup specifically requires it. Can you just return -EEXIST if reusing an existing one and make it a normal private pointer a we use elsewhere? Btw, two things I came up with to make the lease filesystem API nicer: - bypass vfs_setlease/->setlease for deletes and just call directly into the lease code. no one does anything special for it (except cifs, which forgets about it), and then rename the method to ->add_lease. - provide a no_add_lease for nfs/gfs to centralize the no-op version in a single place (similar no no_lseek). Otherwise this looks really nice. -- To unsubscribe from this list: send the line "unsubscribe linux-cifs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
