Re: [PATCH] [CIFS] Incorrect error returned on setting file compressed on SMB2

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 18 Aug 2014 22:33:06 -0500, Steve French wrote:

> When the server (for an SMB2 or SMB3 mount) doesn't support
> an ioctl (such as setting the compressed flag
> on a file) we were incorrectly returning EIO instead
> of EOPNOTSUPP, this is confusing e.g. doing chattr +c to a file
> on a non-btrfs Samba partition, now the error returned is more
> intuitive to the user.
> 
> Signed-off-by: Steve French <smfrench@xxxxxxxxx>

Reviewed-by: David Disseldorp <ddiss@xxxxxxx>

Looks like the cifs_hardlink() -EIO to -EOPNOTSUPP mapping logic could
potentially also be removed with this change.

Cheers, David
--
To unsubscribe from this list: send the line "unsubscribe linux-cifs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux