2014-07-25 5:06 GMT+04:00 Shirish Pargaonkar <shirishpargaonkar@xxxxxxxxx>: > Looks correct. > > Reviewed-by: Shirish Pargaonkar <spargaonkar@xxxxxxxx> Thank you for reviewing the series! > Only comment would be, wish there was a mnemonic/define for > a regular op when calling add_credits_and_wake_if() for optype > such as CIFS_ECHO_OP or CIFS_OPBREAK_OP instead of 0. Yes, it can make sense but should be in another patch/series. > Oh and super nitpick... s/reseted/reset/. Ok, will fix it in my smb2-dev branch on git.altlinux.org. -- Best regards, Pavel Shilovsky. -- To unsubscribe from this list: send the line "unsubscribe linux-cifs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html