2014-07-20 23:49 GMT+04:00 Shirish Pargaonkar <shirishpargaonkar@xxxxxxxxx>: > why bother setting rc (to ENOTSUPP, ENOMEM) if those errors are not returned > once we break out of do while loop? > Instead perhaps log an error message? Good point, thanks. It seems like we should call mapping_set_error(mapping, rc) in the end of the function. In this case setting rc looks ok. Also, I think we don't need to log messages in this case. -- Best regards, Pavel Shilovsky. -- To unsubscribe from this list: send the line "unsubscribe linux-cifs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html