Although I have merged this into cifs-2.6.git for-next, in my testing I am also seeing this fail with vers=3.0 (and probably 2.0 and 2.1) so I would like to fix that too (and mfsymlinks may be at least as important there) On Mon, Jun 16, 2014 at 8:49 AM, Stefan (metze) Metzmacher <metze@xxxxxxxxx> wrote: > Hi Steve, > > any comments on this? How can we get this fixed upstream? > > Thanks! > metze > > Am 10.06.2014 12:03, schrieb Björn Baumbach: >> commit d81b8a40e2ece0a9ab57b1fe1798e291e75bf8fc >> ("CIFS: Cleanup cifs open codepath") >> changed disposition to FILE_OPEN. >> >> Signed-off-by: Björn Baumbach <bb@xxxxxxxxx> >> Signed-off-by: Stefan Metzmacher <metze@xxxxxxxxx> >> Reviewed-by: Stefan Metzmacher <metze@xxxxxxxxx> >> Cc: <stable@xxxxxxxxxxxxxxx> # v3.14+ >> Cc: Pavel Shilovsky <piastry@xxxxxxxxxxx> >> Cc: Steve French <sfrench@xxxxxxxxx> >> --- >> fs/cifs/link.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/fs/cifs/link.c b/fs/cifs/link.c >> index 264ece7..68559fd 100644 >> --- a/fs/cifs/link.c >> +++ b/fs/cifs/link.c >> @@ -374,7 +374,7 @@ cifs_create_mf_symlink(unsigned int xid, struct cifs_tcon *tcon, >> oparms.cifs_sb = cifs_sb; >> oparms.desired_access = GENERIC_WRITE; >> oparms.create_options = create_options; >> - oparms.disposition = FILE_OPEN; >> + oparms.disposition = FILE_CREATE; >> oparms.path = path; >> oparms.fid = &fid; >> oparms.reconnect = false; >> > -- Thanks, Steve -- To unsubscribe from this list: send the line "unsubscribe linux-cifs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html