On Fri, May 2, 2014 at 2:53 PM, Jeff Layton <jlayton@xxxxxxxxxxxxxxx> wrote: > On Wed, 23 Apr 2014 14:40:56 -0400 > Mike Pagano <mpagano@xxxxxxxxxx> wrote: > >> If a cifs mount is attempted without mount.cifs present on the >> system the following appears via dmesg: >> >> [ 25.949378] CIFS VFS: No username specified >> >> The purpose of this patch is to better inform the user of the >> possible cause of the error and show a potential solution. >> >> The output for this error condition will look approximately like this: >> >> [ 11.183392] CIFS VFS: No username specified. Could not find >> /sbin/mount.cifs. Please ensure your system has this userspace program >> installed. <snip> > I dunno. This doesn't seem like it's fixing a real problem to me. > > While we highly recommend that people use the mount helper. It's not > specifically *required* per-se. If you can roll up the right mount > options and hand them to the kernel then there's no real problem. > > If you really want this sort of warning, why not put it > into /bin/mount? Then you could even output the warning message to the > terminal instead of the kernel's ring buffer. I don't have a strong opinion on this, although the patch is probably harmless. I slightly prefer that it go in /bin/mount instead of mount.cifs but would reconsider if new arguments in favor of it going in the kernel -- Thanks, Steve -- To unsubscribe from this list: send the line "unsubscribe linux-cifs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
