On Tue, Apr 08, 2014 at 01:23:26PM -0400, Jeff Layton wrote: > > > If you do that then you don't need to use strlen() either. > > > > > > -- > > > Jeff Layton <jlayton@xxxxxxxxx> > > > > Ok, I think you're correct about snprintf. I got it confused with > sprintf, which doesn't always NULL-terminate. > > If it does indeed always null-terminate then there is indeed no harm in > using strlen, it's just not as efficient. Why not instead simply take > the return value of snprintf and use that to determine whether the > output got truncated? I think we'd rather return an error if it is, > than pass in a possibly bogus string to add_key(). Could be done indeed. Sebastian -- ~ perl self.pl ~ $_='print"\$_=\47$_\47;eval"';eval ~ krahmer@xxxxxxx - SuSE Security Team -- To unsubscribe from this list: send the line "unsubscribe linux-cifs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
