On Fri, 22 Nov 2013 06:35:46 -0800 Christoph Hellwig <hch@xxxxxxxxxxxxx> wrote: > Please provide a helper that encapsulates the calls for the different > info levels, and then formats them into a in-kernel sanitized structure > instead of casting around the on the wire structures, similar to how > the directory code translates that various info levels in a cifs_dirent > structure. > Agreed. What we really need to do is to have these functions pass around the container we already have for this: a struct cifs_fattr rather than FILE_ALL_INFO. It's really an API abortion that even the SMB2 calls have to pass around an SMB1 on-the-wire data structure. Gregor, it would be best to do a patchset to fix that mess first and then layer these changes on top of it. -- Jeff Layton <jlayton@xxxxxxxxxx> -- To unsubscribe from this list: send the line "unsubscribe linux-cifs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
