On Sat, 2 Nov 2013 23:47:16 +0400 Pavel Shilovsky <piastryyy@xxxxxxxxx> wrote: > 2013/11/1 Jeff Layton <jlayton@xxxxxxxxxx>: > > This looks much better for performance, but I think it really shines a > > light on what an abortion the query_path_info and query_file_info > > operations are. They work with a FILE_ALL_INFO struct which is SMB1 > > specific, so for SMB2/3 we have to convert data to something that > > doesn't even match the protocol. > > > > I think it would be best to base this fix on top of a patchset to fix > > that properly. Those functions should be changed to pass data around in > > a cifs_fattr. With that, you could just add a new cifs_fattr->flags > > value and you wouldn't need to add this extra bool * argument. > > I agree that using cifs_fattr structure rather than FILE_ALL_INFO > simplifies things and makes the code cleaner. But we have a problem in > the 3.11 stable branch and I think we should fix it without many > patches (code changes). We can apply this patch for stable and then > convert the code to use cifs_fattr structure in query path/file info > in mainline. Right? > If you intend to push a fix to stable for this, then that sounds like the best approach. It will make cleaning up the API harder, but as long as you're ok with that... -- Jeff Layton <jlayton@xxxxxxxxxx> -- To unsubscribe from this list: send the line "unsubscribe linux-cifs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
