Hi Jeff,
Thanks for doing all this work!
Trivial comments below.
On Fri, 21 Jun 2013 08:58:14 -0400 Jeff Layton <jlayton@xxxxxxxxxx> wrote:
>
> +static inline void
> +locks_insert_global_locks(struct file_lock *fl)
> +{
> + list_add_tail(&fl->fl_link, &file_lock_list);
> +}
We generally do not use "inline" in C files any more and leave it to the
compiler to do that. Also, without the "inline" these function headers
should all be able to fit on single lines like the others here i.e.
static void locks_insert_global_locks(struct file_lock *fl)
--
Cheers,
Stephen Rothwell sfr@xxxxxxxxxxxxxxxx
Attachment:
pgpITRREobqsy.pgp
Description: PGP signature
