Hello Steve French,
This is a semi-automatic email about new static checker warnings.
The patch 7f420cee8bd6: "[CIFS] Charge at least one credit, if server
says that it supports multicredit" from Jun 23, 2013, leads to the
following Smatch complaint:
fs/cifs/smb2pdu.c:120 smb2_hdr_assemble()
warn: variable dereferenced before check 'tcon->ses' (see line 115)
fs/cifs/smb2pdu.c
114 if (tcon->ses->server->capabilities & SMB2_GLOBAL_CAP_LARGE_MTU)
^^^^^^^^^^^
New dereference.
115 hdr->CreditCharge = cpu_to_le16(1);
116 /* else CreditCharge MBZ */
117
118 hdr->TreeId = tcon->tid;
119 /* Uid is not converted */
120 if (tcon->ses)
^^^^^^^^^
Old check.
121 hdr->SessionId = tcon->ses->Suid;
122 /* BB check following DFS flags BB */
regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe linux-cifs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
