On Tue, Apr 23, 2013 at 10:01 AM, Jeff Layton <jlayton@xxxxxxxxx> wrote: > On Tue, 23 Apr 2013 08:34:14 -0400 > Scott Lovenberg <scott.lovenberg@xxxxxxxxx> wrote: > >> On Mon, Apr 22, 2013 at 11:09 AM, Jeff Layton <jlayton@xxxxxxxxx> wrote: >> >> Ping. >> >> Any comments? >> >> >> > >> > I guess I don't quite understand why we need this patch. For NFS it's >> > pretty clear that we would since ':' has always served as the delimiter >> > between the hostname and the pathname. >> > >> > For CIFS, not so much... IPv6 addresses typically don't have '/' or '\\' >> > characters in them, so why do we need to wrap them in []? >> > >> > Note that this syntax doesn't follow what Windows does either, AFAIK. >> > There, you need something like this since UNC paths can't contain ':' >> > characters (and maybe also '%'): >> > >> > http://www.samba.org/~idra/code/nss-ipv6literal/README.html >> > >> > ...we have no such restriction under Linux though. >> > >> >> I liked this approach for two reasons. It handles a convention for >> IPv6 formatting that is used that we don't support and allows us to >> (in the future) parse an address from the path instead of having to >> use --ip=, which I feel is a bit cumbersome. Originally I was going >> to just put in support for something like "mount.cifs >> //IPv6Address/share /mnt/path" right away, but I wanted to get this >> part in first. >> > > Again, I'm confused...this sort of syntax seems to work just fine > already: > > # mount -t cifs //fecd::1/share /mnt/cifs -o sec=none,multiuser Hrm, I thought that didn't work (or, more likely, my test environment had some other problem). > > Also, --ip= is not a valid option in the longopts[] array in > mount.cifs (maybe you mean -o ip=). I still don't see what benefit we > receive from allowing someone specify addresses inside of square > brackets. Sorry, posted before my first cup of coffee; -o ip= is what I meant to say. Since this already works, I'm inclined to agree that this patch brings nothing to the table. -- Peace and Blessings, -Scott. -- To unsubscribe from this list: send the line "unsubscribe linux-cifs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
