Your fix looks correct - do you have a problem reproduction scenario
where you encountered this?
On Thu, Apr 4, 2013 at 1:16 AM, Wei Yongjun <weiyj.lk@xxxxxxxxx> wrote:
> From: Wei Yongjun <yongjun_wei@xxxxxxxxxxxxxxxxx>
>
> Fix to return a negative error code from the error handling
> case instead of 0, as returned elsewhere in this function.
>
> Signed-off-by: Wei Yongjun <yongjun_wei@xxxxxxxxxxxxxxxxx>
> ---
> fs/cifs/dir.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/fs/cifs/dir.c b/fs/cifs/dir.c
> index 46e455e..5699b50 100644
> --- a/fs/cifs/dir.c
> +++ b/fs/cifs/dir.c
> @@ -457,8 +457,10 @@ cifs_atomic_open(struct inode *inode, struct dentry *direntry,
> inode, direntry->d_name.name, direntry);
>
> tlink = cifs_sb_tlink(CIFS_SB(inode->i_sb));
> - if (IS_ERR(tlink))
> + if (IS_ERR(tlink)) {
> + rc = PTR_ERR(tlink);
> goto out_free_xid;
> + }
>
> tcon = tlink_tcon(tlink);
> server = tcon->ses->server;
>
--
Thanks,
Steve
--
To unsubscribe from this list: send the line "unsubscribe linux-cifs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
