2013/3/6 Jeff Layton <jlayton@xxxxxxxxxx>: > On Tue, 5 Mar 2013 19:25:55 +0000 > Sachin Prabhu <sprabhu@xxxxxxxxxx> wrote: > >> Fix check for error condition after setting attributes with >> CIFSSMBSetFileInfo(). >> >> Signed-off-by: Sachin Prabhu <sprabhu@xxxxxxxxxx> >> --- >> fs/cifs/inode.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/fs/cifs/inode.c b/fs/cifs/inode.c >> index ed6208f..a183b9d 100644 >> --- a/fs/cifs/inode.c >> +++ b/fs/cifs/inode.c >> @@ -1014,7 +1014,7 @@ cifs_rename_pending_delete(const char *full_path, struct dentry *dentry, >> current->tgid); >> /* although we would like to mark the file hidden >> if that fails we will still try to rename it */ >> - if (rc != 0) >> + if (!rc) >> cifsInode->cifsAttrs = dosattr; >> else >> dosattr = origattr; /* since not able to change them */ > > Nice catch > > Reviewed-by: Jeff Layton <jlayton@xxxxxxxxxx> > -- > To unsubscribe from this list: send the line "unsubscribe linux-cifs" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html Reviewed-by: Pavel Shilovsky <piastry@xxxxxxxxxxx> -- Best regards, Pavel Shilovsky. -- To unsubscribe from this list: send the line "unsubscribe linux-cifs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
