Re: [PATCH] cifs: don't present the cifsFYI procfile when CONFIG_CIFS_DEBUG is disabled

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 20 Dec 2012 15:25:18 -0600
Steve French <smfrench@xxxxxxxxx> wrote:

> You make a good point that we need to adjust cifsFYI when CONFIG_CIFS_DEBUG
> is turned off by embedded distros to save memory but we can't remove it since it
> controls CIFS_RC and CIFS_TIMER messages (which we use for debugging,
> and should work even with CONFIG_CIFS_DEBUG is turned off - to allow
> us to see slow requests and get CIFS/SMB2 network errors logged).
> 
> I am fine with the idea of preventing enabling CIFS_INFO in
> /proc/fs/cifs/cifsFYI
> when CONFIG_CIFS_DEBUG is turned off (e.g. masking off the 0x0004 or
> rejecting it if the user tries to set that bit (to enable various informational
> messages which aren't going to print) when on an embedded system
> with debugging not compiled in).
> 

Fair enough. I'll drop this patch then.

-- 
Jeff Layton <jlayton@xxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-cifs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux