Hi Jeff, I didn't look at the whole patchset in detail, but I think such a new API should support IDMAP_BOTH, which means that a sid can resolve into a uid and a gid at the same time. This is very important as it allows groups to own files e.g. BUILTIN\Administrators is likely to be the owner of a lot of files. And it's the only way to support the 'sIDHistory' for users. metze > This is the second official posting for the plugin interface. Major > changes since the last set are: > > 1/ There's a header file now that plugin implementers are expected to use > > 2/ New manpage for idmapwb.so and cleanups to the existing manpages to > discuss plugin configuration > > 3/ Better handling for the plugin_errmsg variable. A pointer to the > pointer is passed into the init_plugin routine, which allows the > setting of it in the context. > > With this, I think I'm pretty close to something mergeable, but > comments and review are still appreciated. > > Jeff Layton (5): > cifs-utils: struct cifs_sid definition to new cifsidmap.h header > cifs-utils: new plugin architecture for ID mapping code > cifs-utils: convert setcifsacl to use the plugin interface > cifs-utils: convert cifs.idmap to use plugin interface > cifs-utils: add a manpage for idmapwb > > Makefile.am | 37 ++++-- > cifs.idmap.8.in | 22 ++-- > cifs.idmap.c | 93 +++++++-------- > cifsacl.h | 12 +- > cifsidmap.h | 161 ++++++++++++++++++++++++++ > configure.ac | 10 ++ > getcifsacl.1 => getcifsacl.1.in | 5 +- > getcifsacl.c | 98 +++++++--------- > idmap_plugin.c | 160 ++++++++++++++++++++++++++ > idmap_plugin.h | 61 ++++++++++ > idmapwb.8.in | 148 ++++++++++++++++++++++++ > idmapwb.c | 242 ++++++++++++++++++++++++++++++++++++++++ > idmapwb.pod | 26 +++++ > setcifsacl.1 => setcifsacl.1.in | 6 +- > setcifsacl.c | 70 +++--------- > 15 files changed, 952 insertions(+), 199 deletions(-) > create mode 100644 cifsidmap.h > rename getcifsacl.1 => getcifsacl.1.in (87%) > create mode 100644 idmap_plugin.c > create mode 100644 idmap_plugin.h > create mode 100644 idmapwb.8.in > create mode 100644 idmapwb.c > create mode 100644 idmapwb.pod > rename setcifsacl.1 => setcifsacl.1.in (91%) >
Attachment:
signature.asc
Description: OpenPGP digital signature
