On Fri, 30 Nov 2012 06:57:40 -0800 Joe Perches <joe@xxxxxxxxxxx> wrote: > On Fri, 2012-11-30 at 06:56 -0500, Jeff Layton wrote: > > On Thu, 29 Nov 2012 11:37:20 -0800 > > Joe Perches <joe@xxxxxxxxxxx> wrote: > > > > > Rather than havign a permanently enabled #define, allow > > > control over it. > > > > > > This can reduce the size of the module by ~100KB which > > > could be useful for embedded systems. > [] > > > diff --git a/fs/cifs/cifs_debug.h b/fs/cifs/cifs_debug.h > > > index 4d12fe4..6867a7f 100644 > > > --- a/fs/cifs/cifs_debug.h > > > +++ b/fs/cifs/cifs_debug.h > > > @@ -18,7 +18,10 @@ > > > * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA > > > * > > > */ > > > -#define CIFS_DEBUG /* BB temporary */ > > > + > > > +#ifdef CONFIG_CIFS_DEBUG > > > +#define CIFS_DEBUG > > > +#endif > > > > > > #ifndef _H_CIFS_DEBUG > > > #define _H_CIFS_DEBUG > > > > Looks fine, but I'd probably prefer to just get rid of CIFS_DEBUG > > altogether here and replace it with CONFIG_CIFS_DEBUG. > > I wasn't sure if there was other code anywhere else that depends > on CIFS_DEBUG. There isn't any in the kernel source tree. If not, > then you are right, it should be just CONFIG_CIFS_DEBUG. > There shouldn't be. None of this stuff is exposed to userspace, AFAIK. I think it's ok to just make that CONFIG_CIFS_DEBUG. > > While you're at it, /proc/fs/cifs/cifsFYI should probably not be > > present when CONFIG_CIFS_DEBUG isn't set. Perhaps we should also > > disable traceSMB and its related functions too in that case? > > That could be considered a kernel api change. > If people agree to delete it, I'd be OK with it. > If you compile with CONFIG_CIFS_DEBUG turned off, then the cifsFYI file will be a knob that's not hooked up to anything. I think it's best not to present it at all in that case. traceSMB is a little harder to make the case for. Theoretically, it'll still work after your changes, but I'm not sure it makes sense to leave that knob around since it's technically a flag for debugging. You're probably fine not to worry about that one. I'll look at that at some point in the future. Thanks, -- Jeff Layton <jlayton@xxxxxxxxxx> -- To unsubscribe from this list: send the line "unsubscribe linux-cifs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
