Re: [PATCH] cifs: Do not lookup hashed negative dentry in cifs_atomic_open

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 2012-10-30 at 22:30 +0400, Pavel Shilovsky wrote:
> >         if (!(oflags & O_CREAT)) {
> > +               /* Check for hashed negative dentry. We have already
> revalidated
> > +                * the dentry and it is fine. No need to perform
> another lookup.
> > +                */
> 
> Patch looks ok, but the comment above doesn't match the kernel
> CodingStyle for block comments. While cifs code has a many places
> where it doesn't follow the style, we should keep new code as clean as
> possible. 

Sorry about that. I had passed it through checkpatch.pl and it came out
fine. I checked the codestyle document and it appears that this style is
preferred only for files in net/ and drivers/net/. I am sending a v2 of
the patch with the small cosmetic change to ensure that it follows the
Coding Style.

Sachin Prabhu

--
To unsubscribe from this list: send the line "unsubscribe linux-cifs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux