Re: [PATCH 0/7] cifs.idmap: set timeout on keys and generic cleanups

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, Oct 27, 2012 at 6:20 AM, Jeff Layton <jlayton@xxxxxxxxx> wrote:
> This patchset does a number of cleanups to the cifs.idmap request-key
> callout program. It also makes it so that it will set a timeout on the
> keys that it instantiates.
>
> Most of the fixes are to add extra bounds checking, fix unsigned vs.
> signed type confusion, and to avoid unnecessary memory allocations.
>
> Jeff Layton (7):
>   cifs.idmap: make sure cifsacl structs are packed
>   cifs.idmap: get rid of useless strcmp prior to idmapping
>   cifs.idmap: add an options struct to handle long options
>   cifs.idmap: clean up strget and avoid memory allocation
>   cifs.idmap: don't use atoi to convert unsigned int to number
>   cifs.idmap: set a timeout on keys that it instantiates
>   cifs.idmap: add a --help option for cifs.idmap
>
>  cifs.idmap.8.in |  12 +++++-
>  cifs.idmap.c    | 113 +++++++++++++++++++++++++++++++++++++++++---------------
>  cifsacl.h       |   8 ++--
>  3 files changed, 98 insertions(+), 35 deletions(-)
>
> --
> 1.7.11.7
>

This entire patchset looks correct to me.
Should I wait for for respin of 6/7 (just a one line/call change)
before adding reviewd by comment?

Regards,

Shirish
--
To unsubscribe from this list: send the line "unsubscribe linux-cifs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux