[PATCH 1/7] cifs.idmap: make sure cifsacl structs are packed

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



The kernel equivalent definitions are defined with
__attribute__((packed)), and the code seems to assume the userspace and
kernel ones will be properly aligned. Fix the userspace definitions in a
similar fashion.

Given the way these structs are, there is probably not any padding
between fields on most arches, but it's best to be safe here.

Signed-off-by: Jeff Layton <jlayton@xxxxxxxxx>
---
 cifsacl.h | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/cifsacl.h b/cifsacl.h
index 4ea7fd4..101881b 100644
--- a/cifsacl.h
+++ b/cifsacl.h
@@ -110,20 +110,20 @@ struct cifs_ntsd {
 	uint32_t gsidoffset;
 	uint32_t sacloffset;
 	uint32_t dacloffset;
-};
+} __attribute__((packed));
 
 struct cifs_sid {
 	uint8_t revision; /* revision level */
 	uint8_t num_subauth;
 	uint8_t authority[6];
 	uint32_t sub_auth[5]; /* sub_auth[num_subauth] */
-};
+} __attribute__((packed));
 
 struct cifs_ctrl_acl {
 	uint16_t revision; /* revision level */
 	uint16_t size;
 	uint32_t num_aces;
-};
+} __attribute__((packed));
 
 struct cifs_ace {
 	uint8_t type;
@@ -131,6 +131,6 @@ struct cifs_ace {
 	uint16_t size;
 	uint32_t access_req;
 	struct cifs_sid sid; /* ie UUID of user or group who gets these perms */
-};
+} __attribute__((packed));
 
 #endif /* CIFSACL_H */
-- 
1.7.11.7

--
To unsubscribe from this list: send the line "unsubscribe linux-cifs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux