Just some nits I noticed while trying to understand how this code works. Nothing in here that can't wait until 3.8... Jeff Layton (4): cifs: clean up id_mode_to_cifs_acl cifs: move num_subauth check inside of CONFIG_CIFS_DEBUG2 check in parse_sid() cifs: use the NUM_AUTHS and NUM_SUBAUTHS constants in cifsacl code cifs: make compare_sids static fs/cifs/cifsacl.c | 159 +++++++++++++++++++++++++++--------------------------- fs/cifs/cifsacl.h | 6 +-- 2 files changed, 81 insertions(+), 84 deletions(-) -- 1.7.11.7 -- To unsubscribe from this list: send the line "unsubscribe linux-cifs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html