On Fri, 12 Oct 2012 07:41:33 -0400
Scott Lovenberg <scott.lovenberg@xxxxxxxxx> wrote:
> On Fri, Oct 12, 2012 at 7:39 AM, Scott Lovenberg
> <scott.lovenberg@xxxxxxxxx> wrote:
> > In mount.cifs.c's parse_unc(), there's a FIXME to support IPv6 path
> > parsing. Is there any reason that simply grabbing the last instance
> > of the ':' character wouldn't work? Something like this:
> > @@ -1342,7 +1342,7 @@ static int parse_unc(const char *unc_name,
> > struct parsed_mount_info *parsed_info
> > * FIXME: IPv6 addresses?
> > */
> > host = unc_name;
> > - share = strchr(host, ':');
> > + share = strrchr(host, ':');
> > if (!share) {
> > fprintf(stderr, "mount.cifs: bad UNC (%s)\n", unc_name);
> > return EX_USAGE;
> >
> >
> > I'm reasonably sure that somebody smarter than myself has already
> > thought of this, so there must be more to the problem that I'm seeing.
> > --
> > Peace and Blessings,
> > -Scott.
>
> *... than I'm seeing.* (/me needs to proofread _before_ hitting "send").
>
What if some component of the pathname has a ':' in it? For instance:
<ip6 address>:/share/foo:bar/baz/
Personally, I'd rather see us deprecate the "nfs syntax". I don't see
that that provides us any value. We've never documented that it was
supported, so maybe a patch to warn for a couple of releases when
someone uses it and then rip it out?
--
Jeff Layton <jlayton@xxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-cifs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
