On Thu, Sep 27, 2012 at 3:17 AM, Pavel Shilovsky <piastry@xxxxxxxxxxx> wrote: > 2012/9/27 Steve French <smfrench@xxxxxxxxx>: >> merged into cifs-2.6.git (along with the other two in this > > What do you think about Cc'ing it to stable@xxxxxxxxxxxxxxx as well? I don't think it is necessary but if you think a problem is reproducible let me know. In the case where resp_buf_type == CIFS_NO_BUFFER then we have iov pointing to the original request and therefore smb_buf->Status.CifsError == cpu_to_le32(NT_STATUS_MORE_PROCESSING_REQUIRED will never be true Your code (adding the check for resp_buf_type) makes it cleaner and better, but I don't see how we can end up oopsing or falling into this section of code accidentally with the previous version. -- Thanks, Steve -- To unsubscribe from this list: send the line "unsubscribe linux-cifs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html