Re: checkpatch warning on single statement do ... while

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 14 Sep 2012 10:51:04 -0500
Steve French <smfrench@xxxxxxxxx> wrote:

> Any thoughts about this checkpatch warning? (We have the same kind of
> thing in cifssmb.c)
> 
> WARNING: Single statement macros should not use a do {} while (0) loop
> #65: FILE: fs/cifs/cifsglob.h:608:
> +#define cifs_kmap_lock() do { ; } while (0)
> 
> WARNING: Single statement macros should not use a do {} while (0) loop
> #66: FILE: fs/cifs/cifsglob.h:609:
> +#define cifs_kmap_unlock() do { ; } while (0)
> 
> total: 0 errors, 2 warnings, 307 lines checked
> 
> /home/stevef/3.7-patches/0019-CIFS-Add-SMB2-support-for-cifs_iovec_write.patch
> has style problems, please review.
> 
> 
> --
> Thanks,
> 
> Steve
> 
> 

I think it's not worth worrying about since a later patch removes those
macros altogether.

-- 
Jeff Layton <jlayton@xxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-cifs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux