On Mon, Sep 10, 2012 at 12:11 PM, Scott Lovenberg
<scott.lovenberg@xxxxxxxxx> wrote:
>
> >> > > @@ -351,12 +351,17 @@ int cifs_get_inode_info_unix(struct inode **pinode,
> >> > > cFYI(1, "CIFSCheckMFSymlink: %d", tmprc);
> >> > > }
> >> > >
> >> > > + if (strstr(full_path, ":"))
> >> > > + fattr.cf_flags |= S_PRIVATE;
> >> > > +
> >> > > if (*pinode == NULL) {
> >> > > /* get new inode */
> >> > > cifs_fill_uniqueid(sb, &fattr);
> >> > > *pinode = cifs_iget(sb, &fattr);
> >> > > if (!*pinode)
> >> > > rc = -ENOMEM;
> >> > > + if (strstr(full_path, ":"))
> >> > > + (*pinode)->i_flags |= S_PRIVATE;
>
> ^ On -ENOMEM you dereference a null pointer, don't you? Same thing in
> cifs_get_inode_info().
>
yes, Thanks Scott. Will fix that. Should be done on an else.
Waiting for Jeff's comments before I respinsubmit the patch.
Regards,
Shirish
>
>
> --
> Peace and Blessings,
> -Scott.
--
To unsubscribe from this list: send the line "unsubscribe linux-cifs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
