Re: [PATCH 01/11] cifs: remove bogus reset of smb_buf_length in smb_send routines

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



2012/7/25 Pavel Shilovsky <piastryyy@xxxxxxxxx>:
> 2012/7/18 Jeff Layton <jlayton@xxxxxxxxxx>:
>> There's a comment here about how we don't want to modify this length,
>> but nothing in this function actually does.
>>
>> Signed-off-by: Jeff Layton <jlayton@xxxxxxxxxx>
>> ---
>>  fs/cifs/transport.c |    4 ----
>>  1 file changed, 4 deletions(-)
>>
>> diff --git a/fs/cifs/transport.c b/fs/cifs/transport.c
>> index 3097ee5..fa51913 100644
>> --- a/fs/cifs/transport.c
>> +++ b/fs/cifs/transport.c
>> @@ -126,7 +126,6 @@ smb_sendv(struct TCP_Server_Info *server, struct kvec *iov, int n_vec)
>>         int rc = 0;
>>         int i = 0;
>>         struct msghdr smb_msg;
>> -       __be32 *buf_len = (__be32 *)(iov[0].iov_base);
>>         unsigned int len = iov[0].iov_len;
>>         unsigned int total_len;
>>         int first_vec = 0;
>> @@ -235,9 +234,6 @@ smb_sendv(struct TCP_Server_Info *server, struct kvec *iov, int n_vec)
>>         else
>>                 rc = 0;
>>
>> -       /* Don't want to modify the buffer as a side effect of this call. */
>> -       *buf_len = cpu_to_be32(smb_buf_length);
>> -
>>         return rc;
>>  }
>>
>> --
>> 1.7.10.4
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-cifs" in
>> the body of a message to majordomo@xxxxxxxxxxxxxxx
>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>
> Reviewed-by: Pavel Shilovsky <pshilovsky@xxxxxxxxx

(sorry for the typo)

Reviewed-by: Pavel Shilovsky <pshilovsky@xxxxxxxxx>

-- 
Best regards,
Pavel Shilovsky.
--
To unsubscribe from this list: send the line "unsubscribe linux-cifs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux