Re: [PATCH v2 02/24] CIFS: Rename 7 error codes to NT_ style

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



2012/6/21 Jeff Layton <jlayton@xxxxxxxxxxxxxxx>:
> On Wed, 20 Jun 2012 18:30:42 +0400
> Pavel Shilovsky <pshilovsky@xxxxxxxxx> wrote:
>
>> and consider such codes as CIFS errors.
>>
>> Signed-off-by: Pavel Shilovsky <pshilovsky@xxxxxxxxx>
>> ---
>>  fs/cifs/nterr.c |    6 +++---
>>  fs/cifs/nterr.h |   26 ++++++++++++++------------
>>  2 files changed, 17 insertions(+), 15 deletions(-)
>>
>> diff --git a/fs/cifs/nterr.c b/fs/cifs/nterr.c
>> index 819fd99..908a3c7 100644
>> --- a/fs/cifs/nterr.c
>> +++ b/fs/cifs/nterr.c
>> @@ -31,7 +31,7 @@ const struct nt_err_code_struct nt_errs[] = {
>>       {"NT_STATUS_INVALID_INFO_CLASS", NT_STATUS_INVALID_INFO_CLASS},
>>       {"NT_STATUS_INFO_LENGTH_MISMATCH", NT_STATUS_INFO_LENGTH_MISMATCH},
>>       {"NT_STATUS_ACCESS_VIOLATION", NT_STATUS_ACCESS_VIOLATION},
>> -     {"STATUS_BUFFER_OVERFLOW", STATUS_BUFFER_OVERFLOW},
>> +     {"STATUS_BUFFER_OVERFLOW", NT_STATUS_BUFFER_OVERFLOW},
>
> Should you also change the text version of these names? Since we print
> those when debugging, then it might be nice to have them match the
> actual #define names.

Yes, it makes sense. I've fixed it in smb2-mount branch and will
respost when we finish with other patches from the series.

-- 
Best regards,
Pavel Shilovsky.
--
To unsubscribe from this list: send the line "unsubscribe linux-cifs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux