On 06/12/2012 03:49 PM, Jeff Layton wrote: > I think in hindsight, that adding -Werror by default was a mistake. > cifs-utils is built in a wide range of environments and tools, and it's > very difficult to eliminate all of the possible warnings. > > Let's go ahead and remove it and reduce the steady trickle of patches > that are simply to silence obscure warnings. > > Cc: Suresh Jayaraman <sjayaraman@xxxxxxxx> > Signed-off-by: Jeff Layton <jlayton@xxxxxxxxx> > --- > Makefile.am | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/Makefile.am b/Makefile.am > index 05729ca..b412262 100644 > --- a/Makefile.am > +++ b/Makefile.am > @@ -1,4 +1,4 @@ > -AM_CFLAGS = -Wall -Wextra -Werror -D_FORTIFY_SOURCE=2 > +AM_CFLAGS = -Wall -Wextra -D_FORTIFY_SOURCE=2 > ACLOCAL_AMFLAGS = -I aclocal > + 1 Sounds like the right thing to do. Acked-by: Suresh Jayaraman <sjayaraman@xxxxxxxx> -- To unsubscribe from this list: send the line "unsubscribe linux-cifs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html