2012/5/30 Pavel Shilovsky <pshilovsky@xxxxxxxxx>: > Thanks for the review! > > As for the macro itself. Instead of this: > > if (S_OP(server, check_trans2, false, mid, server, buf, malformed)) > return; > > we will have: > > if (server->ops->check_trans2 && server->ops->check_trans2(mid, > server, buf, malformed)) > return; > > that looks bigger. > > And for non-void functions: > > rc = server->ops->negotiate? server->ops->negotiate(server, xid, ses)) > : -ENOSYS; > > the macro reduces this place to > > rc = S_OP(server, negotiate, -ENOSYS, xid, ses); > > that also looks more compact. > > I am not sure that the name of the macro is ideal - suggestions are welcome! > > -- > Best regards, > Pavel Shilovsky. Sorry - email web client split the lines. -- Best regards, Pavel Shilovsky. -- To unsubscribe from this list: send the line "unsubscribe linux-cifs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
