On Tue, 24 Apr 2012 15:28:30 +0100 Sachin Prabhu <sprabhu@xxxxxxxxxx> wrote: > cifs_show_options uses the wrong conversion specifier for uid, gid, > rsize & wsize. Correct this to %u to match it to the variable type > 'unsigned integer'. > > Signed-off-by: Sachin Prabhu <sprabhu@xxxxxxxxxx> > --- > fs/cifs/cifsfs.c | 8 ++++---- > 1 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/fs/cifs/cifsfs.c b/fs/cifs/cifsfs.c > index ea8eb92..811245b 100644 > --- a/fs/cifs/cifsfs.c > +++ b/fs/cifs/cifsfs.c > @@ -370,13 +370,13 @@ cifs_show_options(struct seq_file *s, struct dentry *root) > (int)(srcaddr->sa_family)); > } > > - seq_printf(s, ",uid=%d", cifs_sb->mnt_uid); > + seq_printf(s, ",uid=%u", cifs_sb->mnt_uid); > if (cifs_sb->mnt_cifs_flags & CIFS_MOUNT_OVERR_UID) > seq_printf(s, ",forceuid"); > else > seq_printf(s, ",noforceuid"); > > - seq_printf(s, ",gid=%d", cifs_sb->mnt_gid); > + seq_printf(s, ",gid=%u", cifs_sb->mnt_gid); > if (cifs_sb->mnt_cifs_flags & CIFS_MOUNT_OVERR_GID) > seq_printf(s, ",forcegid"); > else > @@ -439,8 +439,8 @@ cifs_show_options(struct seq_file *s, struct dentry *root) > if (cifs_sb->mnt_cifs_flags & CIFS_MOUNT_CIFS_BACKUPGID) > seq_printf(s, ",backupgid=%u", cifs_sb->mnt_backupgid); > > - seq_printf(s, ",rsize=%d", cifs_sb->rsize); > - seq_printf(s, ",wsize=%d", cifs_sb->wsize); > + seq_printf(s, ",rsize=%u", cifs_sb->rsize); > + seq_printf(s, ",wsize=%u", cifs_sb->wsize); > /* convert actimeo and display it in seconds */ > seq_printf(s, ",actimeo=%lu", cifs_sb->actimeo / HZ); > Reviewed-by: Jeff Layton <jlayton@xxxxxxxxxx> -- To unsubscribe from this list: send the line "unsubscribe linux-cifs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
