On 04/20/2012 12:54 AM, Jeff Layton wrote:
> I'm not sure what I was thinking when I added that check in, but it's
> been there since the inception. We shouldn't care at all what the
> real uid is when we call toggle_dac_capability and indeed we don't
> care with the libcap-ng version. Remove that check.
No specific comments on the patch itself but I don't understand the
changelog. This code corresponds to the #else part of #ifdef
HAVE_LIBCAP_NG and doesn't have any relevance to the libcap-ng?
Or did you mean we didn't have to consider this check for #ifdef
HAVE_LIBCAP_NG part?
Thanks
Suresh
> Signed-off-by: Jeff Layton <jlayton@xxxxxxxxx>
> ---
> mount.cifs.c | 3 ---
> 1 files changed, 0 insertions(+), 3 deletions(-)
>
> diff --git a/mount.cifs.c b/mount.cifs.c
> index 06715dd..c90ce3e 100644
> --- a/mount.cifs.c
> +++ b/mount.cifs.c
> @@ -552,9 +552,6 @@ toggle_dac_capability(int writable, int enable)
> cap_t caps;
> cap_value_t capability = writable ? CAP_DAC_OVERRIDE : CAP_DAC_READ_SEARCH;
>
> - if (getuid() != 0)
> - return 0;
> -
> caps = cap_get_proc();
> if (caps == NULL) {
> fprintf(stderr, "Unable to get current capability set: %s\n",
--
To unsubscribe from this list: send the line "unsubscribe linux-cifs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
