On 04/17/2012 03:03 AM, Steve French wrote: > Good idea - thx > > On Mon, Apr 16, 2012 at 1:13 PM, Jeff Layton <jlayton@xxxxxxxxx> wrote: >> With the recent patch to fix the warnings in asn1.c, cifs-utils now >> builds without any warnings. Ban them henceforth by adding -Werror for >> builds. >> >> Signed-off-by: Jeff Layton <jlayton@xxxxxxxxx> >> --- >> Makefile.am | 2 +- >> 1 files changed, 1 insertions(+), 1 deletions(-) >> >> diff --git a/Makefile.am b/Makefile.am >> index 17ad8e1..d95142a 100644 >> --- a/Makefile.am >> +++ b/Makefile.am >> @@ -1,4 +1,4 @@ >> -AM_CFLAGS = -Wall -Wextra >> +AM_CFLAGS = -Wall -Wextra -Werror >> ACLOCAL_AMFLAGS = -I aclocal Any thoughts on making a similar change to the cifs kernel module Makefile as well? I see from the sources that some of arch/ code, a few drivers and perf are already using it. Perf Makefile treats warnings as errors unless directed not to and there is a flag to disable treating any warnings as error (for e.g. by passing WERROR=0). Suresh -- To unsubscribe from this list: send the line "unsubscribe linux-cifs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
