On Fri, 13 Apr 2012 14:04:32 +0100 Sachin Prabhu <sprabhu@xxxxxxxxxx> wrote: > The function kstrtoul() used to parse number strings in the mount > option parser is set to expect a base 10 number . This treats the octal > numbers passed for mount options such as file_mode as base10 numbers > leading to incorrect behavior. > > Change the 'base' argument passed to kstrtoul from 10 to 0 to > allow it to auto-detect the base of the number passed. > > Signed-off-by: Sachin Prabhu <sprabhu@xxxxxxxxxx> > Reported-by: Chris Clayton <chris2553@xxxxxxxxxxxxxx> > > --- > fs/cifs/connect.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/fs/cifs/connect.c b/fs/cifs/connect.c > index 6a86f3d..f31dc9a 100644 > --- a/fs/cifs/connect.c > +++ b/fs/cifs/connect.c > @@ -1123,7 +1123,7 @@ static int get_option_ul(substring_t args[], unsigned long *option) > string = match_strdup(args); > if (string == NULL) > return -ENOMEM; > - rc = kstrtoul(string, 10, option); > + rc = kstrtoul(string, 0, option); > kfree(string); > > return rc; Acked-by: Jeff Layton <jlayton@xxxxxxxxx> -- To unsubscribe from this list: send the line "unsubscribe linux-cifs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
