On Tue, 2012-04-10 at 08:23 +0100, Chris Clayton wrote: > HI, > > I'm testing the latest and greatest from Linus' tree and can't mount partitions > on a nas server. The mounts work fine with 3.3.1. For the failing kernel, git > describe gives v3.4-rc2-2-g258f742. > > What I see is: > > [chris:~]$ sudo mount /media/nas/share > mount error(22): Invalid argument > Refer to the mount.cifs(8) manual page (e.g. man mount.cifs) > > Dmesg shows the message: > > CIFS: Unknown mount option "user=" > > The related entry in /etc/fstab is: > > //nas/Share /media/nas/share cifs > rw,noauto,nosuid,nodev,user,guest,uid=1000,gid=100,file_mode=0666 0 0 > > Let me know how I can help fix this regression. > > Please cc me - I'm not subscribed. > > Thanks > > Chris Chris, This was caused due to a regression introduced by the patch with commit 8830d7e07a5e38bc47650a7554b7c1cfd49902bf which cleaned up the mount options parser. The patch doesn't handle blank user= mount option passed as a mount option. The patch is trivial and requires similar handling as the blank password option. http://article.gmane.org/gmane.linux.kernel.cifs/5762 Sachin Prabhu -- To unsubscribe from this list: send the line "unsubscribe linux-cifs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html