On Wed, 14 Mar 2012 14:30:23 -0500 Steve French <smfrench@xxxxxxxxx> wrote: > I don't mind reviewing this, but it does appear to change behaviour > significantly from existing code. Does this fix a reported bug? > Technically no, but it's horribly ugly code and that makes it difficult to maintain. Look . It's long been a pain point for cifs.ko maintenance. Now that we're looking at SMB2 code, I for one am keen on eliminating that pain now before it's a similar problem there. > The linux cifs kernel driver, like some other > network clients, allows partial option matching to ease > usability for users of other platforms (e.g. "pass" or > "passwd" or "password" are intentionally all accepted > since we match on the first four bytes of that keyword). > Is there a way to get that to work with your patchset. > I worry that some users will be confused that their > mount options won't work if this is taken. > I consider the existing behavior a bug (though a minor one). The question is not so much those, but the fact that the existing parser also accepts stuff like "passfoobarbaz=". We can certainly make the standard token parser accept common and *advertised* mount option abbreviations. If it breaks someone who's using "passfoobarbz=" then I personally don't care very much. We've never claimed that that option would work, and thus if it breaks then I wouldn't consider it a bug. -- Jeff Layton <jlayton@xxxxxxxxxx> -- To unsubscribe from this list: send the line "unsubscribe linux-cifs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
