On Thu 01-03-12 18:29:42, Ted Tso wrote: > On Thu, Mar 01, 2012 at 12:41:34PM +0100, Jan Kara wrote: > > > > To fix the issue, this patch set changes page fault code to call > > file_update_time() only when ->page_mkwrite() callback is not provided. If the > > callback is provided, it is the responsibility of the filesystem to perform > > update of i_mtime / i_ctime if needed. We also push file_update_time() call > > to all existing ->page_mkwrite() implementations if the time update does not > > obviously happen by other means. If you know your filesystem does not need > > update of modification times in ->page_mkwrite() handler, please speak up and > > I'll drop the patch for your filesystem. > > I don't know if this introductory text is going to be saved anywhere > permanent, such as the merge commit (since git now has the ability to > have much more informative merge descriptions). But if it is going to > be preserved, it might be worth mentioning that if the filesystem uses > block_page_mkpage(), it will handled automatically for them since the > patch series does push the call to file_update_time(0 into > __block_page_mkpage(). Good point, added to description. Honza -- Jan Kara <jack@xxxxxxx> SUSE Labs, CR -- To unsubscribe from this list: send the line "unsubscribe linux-cifs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
