Re: [PATCH 2/3] cifs: clean up ordering in exit_cifs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Feb 17, 2012 at 8:31 AM, Jeff Layton <jlayton@xxxxxxxxxx> wrote:
> ...ensure that we undo things in the reverse order from the way they
> were done. In truth, the ordering doesn't matter for a lot of these,
> but it's still better to do it that way to be sure.
>
> Signed-off-by: Jeff Layton <jlayton@xxxxxxxxxx>
> ---
>  fs/cifs/cifsfs.c |   10 +++++-----
>  1 files changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/fs/cifs/cifsfs.c b/fs/cifs/cifsfs.c
> index f5fa651..a848082 100644
> --- a/fs/cifs/cifsfs.c
> +++ b/fs/cifs/cifsfs.c
> @@ -1180,8 +1180,7 @@ static void __exit
>  exit_cifs(void)
>  {
>        cFYI(DBG2, "exit_cifs");
> -       cifs_proc_clean();
> -       cifs_fscache_unregister();
> +       unregister_filesystem(&cifs_fs_type);
>        cifs_dfs_release_automount_timer();
>  #ifdef CONFIG_CIFS_ACL
>        cifs_destroy_idmaptrees();
> @@ -1190,10 +1189,11 @@ exit_cifs(void)
>  #ifdef CONFIG_CIFS_UPCALL
>        unregister_key_type(&cifs_spnego_key_type);
>  #endif
> -       unregister_filesystem(&cifs_fs_type);
> -       cifs_destroy_inodecache();
> -       cifs_destroy_mids();
>        cifs_destroy_request_bufs();
> +       cifs_destroy_mids();
> +       cifs_destroy_inodecache();
> +       cifs_fscache_unregister();
> +       cifs_proc_clean();
>  }
>
>  MODULE_AUTHOR("Steve French <sfrench@xxxxxxxxxx>");
> --
> 1.7.7.6
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-cifs" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

Looks correct.

Acked-by: Shirish Pargaonkar <shirishpargaonkar@xxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-cifs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux