Re: [PATCH v3 00/15] cifscreds: cleanup and overhaul of cifscreds utility

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri,  6 Jan 2012 13:14:32 -0500
Jeff Layton <jlayton@xxxxxxxxx> wrote:

> This patchset is a cleanup and overhaul of the cifscreds utility that
> lives in the cifs-utils tree today. Igor Druzhinin did a wonderful job
> on this when he did the original code a couple of years ago, but I did a
> rather poor job at the time of communicating what we actually need for
> this tool to do. Mea culpa...
> 
> This patch is a third pass at morphing it into a tool that's more like
> what we need. I believe with this, I'll be able to roll some kernel
> patches that can use the stashed key for establishing sessions.
> 
> I've made a few changes since the last set:
> 
> - convert the tool to use the new "secret" key_type that I'm proposing
> 
> - a manpage has been added
> 
> - the key is now prefixed with "cifs:" instead of "cifscreds:"
> 
> The idea here is that we want to be able to allow users to stash their
> NTLM credentials in the kernel, so that it's possible to establish a
> session on the fly when that user walks into a multiuser mount.
> 
> This set should be considered in conjunction with the kernel patchset
> that I proposed earlier today:
> 
>     [PATCH 0/3] cifs: allow multiuser mounts with authtypes besides krb5
> 
> 
> Jeff Layton (15):
>   util: move getusername to util.c
>   cifscreds: add unused attribute to argv parm in cifscreds_clearall
>   cifscreds: eliminate domain parm from most functions
>   cifscreds: remove user parameter from create_description
>   cifscreds: make username part of value instead of description
>   cifscreds: make usage use "return" and have callers return
>   cifscreds: move option parsing into main()
>   cifscreds: make username parameter optional
>   cifscreds: add --domain flag
>   cifscreds: loosen allowed characters in domain names
>   cifscreds: use the session keyring
>   cifscreds: make cifscreds use the "unreadable" keyring
>   cifscreds: make key_search use keyctl_search
>   cifscreds: change prefix on keys to "cifs:" instead of "cifscreds:"
>   cifscreds: add a manpage
> 
>  Makefile.am   |    1 +
>  cifscreds.1   |  188 ++++++++++++++++++++++++++++++++++
>  cifscreds.c   |  311 +++++++++++++++++++++++++--------------------------------
>  cifscreds.pod |   81 +++++++++++++++
>  mount.cifs.c  |   11 --
>  util.c        |   13 +++
>  util.h        |    1 +
>  7 files changed, 418 insertions(+), 188 deletions(-)
>  create mode 100644 cifscreds.1
>  create mode 100644 cifscreds.pod
> 

I've gone ahead and merged this patchset with some small changes to
account for the new "login" key type, and some small changes to the new
manpage.

-- 
Jeff Layton <jlayton@xxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-cifs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux